r0qs

Results 76 comments of r0qs

Hi, I believe we can have this. And maybe add a `--overwrite` flag like the one in `solc` to prevent the name collisions? So the behavior of solc-js and solc...

Hi @reselbob, what version of `solcjs` and `nodejs` are you using? I had no problem running the first or the second command with your code: ``` npm install solcjs --bin...

Hi, it would be great to split the local and remote load logic. However, this is a breaking change that directly affects other projects that already use this feature, like...

Hi, thanks for your contribution. I will close this PR since https://github.com/ethereum/solc-js/pull/615/ already exported the type definitions of the wrapper. About the type definitions for the compiler JSON input/output there...

Hi, thank you very much for the PR, and sorry for the late reply. But I will be closing this PR now since this feature is already supported in the...

Hi, thank you very much for the PR. But as pointed out, reviewing a PR that makes so many changes at once is not practical. However, this motivated others to...

The coverage decrease seems to be because I separated the `downloadCurrentVersion.ts` into two files, exported `getVersionList` and `downloadBinary` to be used on the test, but didn't add tests in case...

> Yeah, definitely. I actually think that in the JS tests we would be better off with mocks both for positive and negative case. I'd consider an actual download an...

I added the unit tests for `downloadBinary` and `getVersionList`. I decided to use a dependency called `nock` to easily mock the HTTPS requests. I also added a dummy certificate that...

Hi, thank you very much for this PR. However, part of what was discussed here was already implemented or is under development in other PRs (e.g. https://github.com/ethereum/solc-js/pull/630), so I will...