qwint
qwint
Could add a prompt, instead of the Exception, explicitly informing the person generating of the risks and allowing them to type 'y' if they are willing to proceed, and throwing...
ah yea, double checked and it's passed in plain as day i forgot about that because my last slew of testing on #2779 was manually writing the urls into launcher.py...
one more thing i didn't notice before, you should add the return typing hints for `prefill_shop_red_potions()` and `prefill_shop_wingboots()`
you put the hint on `put_wingboot_in_shop()` not `prefill_shop_wingboots()` which is the one who returns wingboots count
not certain about the code changes but they seem simple enough but I did test both main and this branch using my world (minit) to submit too many items and...
with minor changes to my apworld (Minit): * to support args in the registered component func * and setting the new game_name and supports_uri component values i was able to...
> Was this tested without any items links as well? was tested earlier in development, but just retested and everything looks fine (almost scared myself because i took default yamls...
tested current nightly with this PR at 2 grubs for goal unshuffled on/off grub shuffled on/off grub_hunt, any, and siblings (just checked to make sure goal didn't send on the...
[AP_87056615475386476842_Spoiler.txt](https://github.com/ArchipelagoMW/Archipelago/files/15444652/AP_87056615475386476842_Spoiler.txt) didn't have the ones i tested before so i just used default yaml + "any" goal + randomizeGrubs on
Just wanted to document my current state of review, all my comments were fully addressed/clarified except: I still dislike the Generate.py change being grouped in here as it has its...