HK: add grub hunt goal

[qwint]

What is this fixing or adding?

makes grub hunt goal option that calculates the total available grubs (including item link replacements) and requires all of them to be gathered for goal completion

Note: this is dependent on game mod updates to enable the goal

How was this tested?

generated with two HK worlds with both item links set to:

  item_links:
    - name: Everygrubby
      item_pool:
        - Grub
      replacement_item: Grub
      link_replacement: true

and:

  item_links:
    - name: Everygrubby
      item_pool:
        - Grub
      replacement_item: Grub
      link_replacement: false

and viewed the spoiler log / playthrough for issues

If this makes graphical changes, please attach screenshots.

[BadMagic100]

This will require a client side change with https://github.com/ArchipelagoMW-HollowKnight/Archipelago.HollowKnight/issues/170

[BadMagic100]

Was this tested without any items links as well?

[ScipioWright]

I recommend also adding an option to not require every grub, such as being able to goal with only 75% of them for example

[qwint]

Was this tested without any items links as well?

was tested earlier in development, but just retested and everything looks fine (almost scared myself because i took default yamls and only 7 grubs were in playthrough!,, i didn't change goal to grub hunt)

[BadMagic100]

Client side now supports this goal on the beta builds https://github.com/ArchipelagoMW-HollowKnight/Archipelago.HollowKnight/commit/396610a16fdce6891a48bd999ef8096ec74873ff

Slot data must be changed to snake case grub_count to work with this change

[BadMagic100]

An observation - grubhunt goal seems to make playthrough very slow. with 5 hks itemlinking grubs + linked replacements playthrough took the better part of a 9min generation

[BadMagic100]

Looks good to me, another quick test on latest commit + the nightly mod would probably be good before sending off for core review, not sure I will get a chance this weekend though

[qwint]

tested current nightly with this PR at 2 grubs for goal unshuffled on/off grub shuffled on/off grub_hunt, any, and siblings (just checked to make sure goal didn't send on the siblings run, did not finish it) and everything worked as expected

did notice some fill errors with item links + randomized grubs, but confirmed on main and with others in discord https://discord.com/channels/731205301247803413/1214608557077700720/1243995991594500206 that it is not a grub nor hk exclusive issue

[BadMagic100]

If you have the spoiler log for the any, can we check that it appears correct with the new logic? Otherwise seems good to me

[BadMagic100]

Client support is being released for this, so slot data is locked in now. https://github.com/hk-modding/modlinks/pull/1406

[qwint]

AP_87056615475386476842_Spoiler.txt

didn't have the ones i tested before so i just used default yaml + "any" goal + randomizeGrubs on

[Exempt-Medic]

@qwint This has conflicts now