David Barrett comments

Results 139 comments of


                                            David Barrett

HIGH: remove all room welcome message related code

What's your ETA for this?

HIGH: "Refactor "Workspace welcome message" to be "Workspace description" (1/2, internal)

it looks like everything is merged? Are we just waiting for deploy of the last PR?

HIGH: "Refactor "Workspace welcome message" to be "Workspace description" (1/2, internal)

Yes, i think we're killing `welcomeNote` entirely, aren't we?

HIGH: "Refactor "Workspace welcome message" to be "Workspace description" (1/2, internal)

Updating to note this is blocked on the completion of https://github.com/Expensify/App/issues/32955 to do final cleanup.

HIGH: "Refactor "Workspace welcome message" to be "Workspace description" (1/2, internal)

Alright, this is off hold! What remains to be done?

[$500] Room - User automatically joins public room when accessing from search list

Let's try to fix this before the next earnings call, which is the next time we will invite a lot of people to a public room.

HIGH: [Reliability] [$250] Stop using `reportAction.originalMessage` or `reportAction.message.text`

Great question. I've updated the original post with a more detailed description of the problem and solutions. Thanks!

HIGH: [Reliability] [$250] Stop using `reportAction.originalMessage` or `reportAction.message.text`

Updated the proposal again (sorry!!!) in light of `message` being in this weird one-element array. Thanks for your understanding and help in cleaning up this mess!

HIGH: [Reliability] [$250] Stop using `reportAction.originalMessage` or `reportAction.message.text`

Great work! What's your ETA for submitting the PR for review?

HIGH: [Reliability] [$250] Stop using `reportAction.originalMessage` or `reportAction.message.text`

Great! @cubuspl42 what is your ETA for review?