App
App copied to clipboard
Expensify
[$500] Room - User automatically joins public room when accessing from search list
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.38-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Precondition:
- Admin and member are in the same workspace
- [Admin] Create a workspace and public room
- [Admin] Do not add the workspace member to the room
- [Employee] Open search list
- [Employee] Search for the workspace visibility room > Click on the room
- Note that employee does not automatically join the workspace visibility room
- [Employee] Search for the public room > Click on the room
Expected Result:
The employee does not automatically join the public room
Actual Result:
The employee joins the public room without consent
Workaround:
Unknowm
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [x] Android: Native
- [x] Android: mWeb Chrome
- [x] iOS: Native
- [x] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [x] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/0d1009b5-530b-4f19-b3ff-1bdfaf203c07
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~016d79ffec2c5589c5
- Upwork Job ID: 1755337783452950528
- Last Price Increase: 2024-02-07
Job added to Upwork: https://www.upwork.com/jobs/~016d79ffec2c5589c5
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)
Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
I can't reproduce this either, I'm unable to find the public room when searching as the employee.
Here's where I can get:
- Admin and member are in the same workspace
- [Admin] Create a workspace and public room
- [Admin] Do not add the workspace member to the room
- [Employee] Open search list
- [Employee] Search for the workspace visibility room > NO ROOM SHOWS
https://github.com/Expensify/App/assets/51066321/e92deb1a-aa05-47f8-96ed-365eea0c1dd9
@lanitochka17 can you help me understand what I might be doing wrong?
@Christinadobrzyn Hello You are not testing with the same workspace. Admin, member and the room must be under the same workspace A. In your video, you using workspace A for admin and room, then workspace B for employee.
Oh perfect! I can reproduce and I think this can be part of VSB. I think this can be external - collecting proposals!
I believe this is a backend issue. When you click on the room from search, it will call the following API:
/api?command=OpenReport
If the report is a workspace room, this is what you get back:
{
...
"notificationPreference": "hidden",
...
}
But when you call the same API on a public room, this is what you get:
{
...
"notificationPreference": "daily",
...
}
It appears that the backend defaults the notificationPreference on public rooms to be daily instead of hidden, as it should (not entirely sure of the ramifications here). In other words, the BE is forcing a user to join a public room every time OpenReport is called.
@Christinadobrzyn, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Thank you for the review @barros001!
@DylanDylann should we change this to an Internal job based on @barros001 review?
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@Christinadobrzyn This is a BE bug, please help to add an internal label
Current assignee @DylanDylann is eligible for the Internal assigner, not assigning anyone new.
Okay, changed the labels - waiting for this one to get picked! thanks for the review @DylanDylann
@Christinadobrzyn, @DylanDylann Eep! 4 days overdue now. Issues have feelings too...
@Christinadobrzyn @DylanDylann this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Testing again - this is happening. Asking the team if we want users to automatically join. https://expensify.slack.com/archives/C066HJM2CAZ/p1708732903429109
Let's try to fix this before the next earnings call, which is the next time we will invite a lot of people to a public room.
Confirmed with the team that we do not want to auto-join someone into a public room. So this will remain open to be fixed by someone internal
reached out in Slack to see if someone might be able to grab this - https://expensify.slack.com/archives/C03TQ48KC/p1709064511759569
@Christinadobrzyn @DylanDylann this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
@Christinadobrzyn @DylanDylann this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!
asking what to do with this job - can it be moved to weekly so we don't need to update it everyday with the same comment - https://expensify.slack.com/archives/C01SKUP7QR0/p1709772958396869