Nate Lampton comments

Results 508 comments of


                                            Nate Lampton

[D8] Support custom list types in `theme_item_list()` for children/nested items

This looks great but I think we can avoid new CSS selectors in the Seven theme by removing an unnecessary selector. See my feedback at https://github.com/backdrop/backdrop/pull/4202#pullrequestreview-2244556185.

Follow-up: evaluate the use of try/catch in image_add_svg_attributes()

Thank you @indigoxela, @klonos, @avpaderno, and @argiepiano! Merged https://github.com/backdrop/backdrop/pull/4797 into 1.x and 1.29.x.

[DX] `hook_layout_info()` should be renamed `hook_layout_template_info()`

Overall this looks great. A well-done renaming that provides backwards-compatibility. I left a few comments in the PR. I think the current approach doesn't actually populate the backwards-compatible `$layout->layout_info` and...

[DX] `hook_layout_info()` should be renamed `hook_layout_template_info()`

This looks great @docwilmot. I created a change record at https://docs.backdropcms.org/change-records/hook_layout_info-renamed-to-hook_layout_template_info and updated the PR to reference it. I updated all the `@since` lines to 1.30.0. I think this is...

[DX] `hook_layout_info()` should be renamed `hook_layout_template_info()`

Merged into 1.x for 1.30.0. Thank you @docwilmot for disambiguating the overloaded term "layout"! Thank you @klonos and @laryn both for your code reviews!

Notice: Undefined index: User roles in config_export_single_form()

Thanks @indigoxela and @avpaderno! Strange fix for sure. I wouldn't say no to a more comprehensive fix that didn't use translated strings but that might be a lot more challenging....

Issue #6431: Filter extended settings lost when saving without settings change

Merged into 1.x and 1.27.x. Thanks @indigoxela!

How to set a fixed width on CKEditor 5 contents?

I am not sure if this would work for your use-case, but if the button wrapping is the primary annoyance, you could re-enable the automatic button collapsing feature of CKEditor...

Issue #1116: Default drop-button action for node types should be 'manage fields'.

Posted some feedback to https://github.com/backdrop/backdrop-issues/issues/1116#issuecomment-139417869.

Issue #6456: Use human-readable labels for modules and permissions in user_filters()

Looks good, thanks @klonos and @avpaderno! I merged this into 1.x and 1.28.x.