Chris Smith

Results 136 comments of Chris Smith

@anton-kstnk Thanks for reporting this. I agree that it looks like an omission in the `idtoken` [`Validator`](https://github.com/googleapis/google-api-go-client/blob/v0.149.0/idtoken/validate.go#L142-L182). @codyoss Is there any reason why we shouldn't add this? Does this library...

> we have other dependencies with newer, unambiguous dependencies on this module Can you explicitly document what these are?

Error in `integration-tests`. Should be resolved by upcoming Go runtimes upgrade. ```Run cd showcase loading github.com/googleapis/gapic-showcase/client: err: exit status 1: stderr: go: errors parsing go.mod: /home/runner/work/gapic-generator-go/gapic-generator-go/showcase/go.mod:[5](https://github.com/googleapis/gapic-generator-go/actions/runs/10373984662/job/28731198980?pr=1551#step:6:6): unknown directive: toolchain```

kokoro error: ```sh apigee/v1/apigee-gen.go:12017:52: not enough arguments in call to gensupport.SendRequest have (context.Context, *"net/http".Client, *"net/http".Request) want (context.Context, *"net/http".Client, *"net/http".Request, bool) ```

In order to get a passing Kokoro presubmit check for this PR, you may want to regenerate all of the clients locally and then commit them in your branch, as...

@rockspore Thank you for exploring the problems I raised in #11665. I think this PR suggests a good beginning for a larger cleanup of `grpctransport`. I would continue it as...

I'd like to keep this PR open until it can be expanded or replaced. However, I am converting it to a Draft since it is incomplete.

Go: https://github.com/googleapis/google-api-go-client/blob/10dbf2b5d87783d3dc3de50ea627e740c784137a/idtoken/idtoken.go#L159 PHP: https://github.com/googleapis/google-auth-library-php/blob/999e9ce8b9d17914f04e1718271a0a46da4de2f3/src/Credentials/ImpersonatedServiceAccountCredentials.php#L74 Javascript: https://github.com/googleapis/google-auth-library-nodejs/blob/02e30d4bd781792ee07a345312efe15e689bf134/src/auth/googleauth.ts#L569

The `google.golang.org/api/idtoken` package is being replaced by the `cloud.google.com/go/auth/credentials/idtoken` package. We may want to move this issue to the googleapis/google-cloud-go repo. The equivalent logic is at: https://github.com/googleapis/google-cloud-go/blob/auth/v0.5.1/auth/credentials/idtoken/file.go#L113