google-api-go-client icon indicating copy to clipboard operation
google-api-go-client copied to clipboard

deps: remove forced dependency on main google-cloud-go module

Open noahdietz opened this issue 1 year ago • 3 comments

We need to force a dependency on the cloud.google.com/go main module to ensure that the module is resolved unambiguously. The issue encountered in #2543 and present in #2552 (see below) is odd though because we have other dependencies with newer, unambiguous dependencies on this module. These should win out during dep resolution, but they aren't for some reason.

Forcing a direct dep on the module resolves the ambiguity but is not an ideal solution.

/root/go/pkg/mod/cloud.google.com/go/[email protected]/internal/internal.go:31:2: ambiguous import: found package cloud.google.com/go/compute/metadata in multiple modules:
	cloud.google.com/go v0.26.0 (/root/go/pkg/mod/cloud.google.com/[email protected]/compute/metadata)
	cloud.google.com/go/compute/metadata v0.3.0 (/root/go/pkg/mod/cloud.google.com/go/compute/[email protected]) (compile)

noahdietz avatar Apr 30 '24 17:04 noahdietz

we have other dependencies with newer, unambiguous dependencies on this module

Can you explicitly document what these are?

quartzmo avatar Apr 30 '24 17:04 quartzmo

we have other dependencies with newer, unambiguous dependencies on this module

Can you explicitly document what these are?

At HEAD before forcing the dep:

$ go mod graph | grep ' cloud.google.com/go@'

cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
google.golang.org/[email protected] cloud.google.com/[email protected]
google.golang.org/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/dataproc/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/vision/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
cloud.google.com/go/[email protected] cloud.google.com/[email protected]
google.golang.org/[email protected] cloud.google.com/[email protected]
google.golang.org/[email protected] cloud.google.com/[email protected]

noahdietz avatar Apr 30 '24 18:04 noahdietz

We should be able to remove this without issue once we remove open census as a dep. That is what is causing us issues today. Per debug.md we can do this anytime after Dec 2, 2024.

codyoss avatar Aug 20 '24 18:08 codyoss