google-api-go-client icon indicating copy to clipboard operation
google-api-go-client copied to clipboard

feat(storage): allow Accept-Encoding header

Open BrennaEpp opened this issue 1 year ago • 3 comments

Fixes #2757

Code needs to be regenerated to match up with the additional parameters in gensupport.

BrennaEpp avatar Aug 27 '24 10:08 BrennaEpp

kokoro error:

apigee/v1/apigee-gen.go:12017:52: not enough arguments in call to gensupport.SendRequest
	have (context.Context, *"net/http".Client, *"net/http".Request)
	want (context.Context, *"net/http".Client, *"net/http".Request, bool)

quartzmo avatar Sep 04 '24 21:09 quartzmo

In order to get a passing Kokoro presubmit check for this PR, you may want to regenerate all of the clients locally and then commit them in your branch, as @codyoss and I usually do. (Recent example in #2670.) You can do it by running make cached in the google-api-go-generator directory. You may also need to run tests locally with the update_golden flag if the golden files are in scope for this change. (See gen_test.go for how that works.)

quartzmo avatar Sep 04 '24 21:09 quartzmo

In order to get a passing Kokoro presubmit check for this PR, you may want to regenerate all of the clients locally and then commit them in your branch, as @codyoss and I usually do. (Recent example in #2670.) You can do it by running make cached in the google-api-go-generator directory. You may also need to run tests locally with the update_golden flag if the golden files are in scope for this change. (See gen_test.go for how that works.)

I updated everything, but am still seeing errors locally (I can't see the kokoro build):

--- FAIL: TestNewClient (0.00s)
    dial_test.go:26: got *oauth2.Transport, want: *httptransport.authTransport
FAIL
FAIL    google.golang.org/api/transport/http    0.347s

This seems unrelated to the changes I made, can you help me fix?

BrennaEpp avatar Sep 18 '24 18:09 BrennaEpp

@BrennaEpp is this a change we are still wanting to land?

codyoss avatar May 28 '25 16:05 codyoss

@BrennaEpp is this a change we are still wanting to land?

@codyoss Yes, it is. @frq-dev will work soon on getting this PR into shape. The first commit of this PR shows what we essentially want to do (without the noise of regenerating everything); I don't think we will change that code so feel free to review now or wait for conflicts etc to be resolved.

BrennaEpp avatar May 29 '25 07:05 BrennaEpp