Results 125 comments of Jun Wu

Mostly look good but names could be a bit more explicit: - Since "pacman" is also used by MinGW, could we use "arch-package" instead of "pacman-package"? - Could we use...

Sorry for the late reply. I have been distracted by other stuffs at work lately. Thanks for the detailed explanation! On bootstrapping and distribution - I agree the current logic...

I didn't really realize `()` is also a valid "tuple" in Rust. I guess there is no easy solution here. Maybe Rust should have a separate `void` type.

The `termwiz` crate provides good Windows + Unix terminal support and it has a buffered terminal.

I can reproduce the crash using a fresh 2.4.0p0 ruby installed by [rbenv](https://github.com/rbenv/rbenv). I think commenting out the `encode!` lines as mentioned by @fran-penedo is a good solution, which may...

遇到了类似的问题。把 gzip 去掉只用 deflate 也不行,加上 UA 也不行,使用不同的网络也不行,看起来一直在读 `dynamic.cloud.vip.xunlei.com/interface/showtask_unfresh?...` 这个页,重试了 10 次就放弃了…… 发现 showtask_unfresh 多了一个参数 `t` 表示时间,加上了似乎也不行,猜测可能是 cookie 的问题了

错误信息和 @zjsywcc 一样之前就没有贴。 ``` % lx list urlread1(http://dynamic.cloud.vip.xunlei.com/user_task?userid=153147329&st=0,{}) Accept-Encoding=gzip, deflate urlread1(http://dynamic.cloud.vip.xunlei.com/interface/showtask_unfresh?type_id=4&page=1&tasknum=100&p=1&interfrom=task,{}) Accept-Encoding=gzip, deflate urlread1(http://dynamic.cloud.vip.xunlei.com/interface/showtask_unfresh?type_id=4&page=1&tasknum=100&p=1&interfrom=task,{}) Accept-Encoding=gzip, deflate urlread1(http://dynamic.cloud.vip.xunlei.com/interface/showtask_unfresh?type_id=4&page=1&tasknum=100&p=1&interfrom=task,{}) Accept-Encoding=gzip, deflate urlread1(http://dynamic.cloud.vip.xunlei.com/interface/showtask_unfresh?type_id=4&page=1&tasknum=100&p=1&interfrom=task,{}) Accept-Encoding=gzip, deflate urlread1(http://dynamic.cloud.vip.xunlei.com/interface/showtask_unfresh?type_id=4&page=1&tasknum=100&p=1&interfrom=task,{}) Accept-Encoding=gzip, deflate urlread1(http://dynamic.cloud.vip.xunlei.com/interface/showtask_unfresh?type_id=4&page=1&tasknum=100&p=1&interfrom=task,{}) Accept-Encoding=gzip, deflate urlread1(http://dynamic.cloud.vip.xunlei.com/interface/showtask_unfresh?type_id=4&page=1&tasknum=100&p=1&interfrom=task,{}) Accept-Encoding=gzip,...

Bisect shows it's a regression introduced in `nightly-2021-08-22`. `nightly-2021-08-21` works fine. Looking at the commits (`git log --graph a0035916e..d3e2578c3 -p`), ["Upgrade to LLVM 13"](https://github.com/rust-lang/rust/commit/db002a06ae9154a35d410550bc5132df883d7baa) looks the most suspicious. I haven't...

Any progress on this? I want this feature too. @tbu- Do you mind if I work on a new pull request?

I think the superior cases are covered by the tests. If you can port the tests then it's easier to see the differences. Basically weave should behave better when adjacent/context...