Results 125 comments of Jun Wu

Yes. One pull request with multiple commits is okay.

`sl` currently runs `git` to perform a clone. Would you get the same error if running the following git commands directly? ``` git -c 'init.defaultBranch=_unused_branch' init -q --bare llvm-git git...

@lorenzhs There was an issue when you set a new ulimit it does not take effect since the daemon still uses the old ulimit. You can try `sl --kill-chg-daemon` to...

To be honest, the current change makes the code harder to read. `$1` is discouraged in Ruby and names like `regexp` and `rex` confuses people. Let's do this instead: If...

Part of the space complexity can manifest as time complexity via the GC. The hung "forever" cases might be actually caused by the space complexity. I didn't observe "out of...

> I don't think GC can possibly increase the time complexity in a way you wouldn't expect if you analyzed the time complexity without regard for GC For example, if...

Git's `xdiff` does some post-processing (ex. shifting the diff chunk up or down, merging adjacent diff chunks) to "normalize" the results.

Regarding on the Sapling/EdenFS integration: Getting the Thrift part working is the first step. The next major blocker is that the [EdenFS -> Sapling integration](https://github.com/facebook/sapling/tree/main/eden/scm/lib/backingstore) does not use abstractions to...

> File "/home/edencommon/build/fbcode_builder/getdeps/builder.py", line 697, in _build > raise Exception("Failed to find CMake") > Exception: Failed to find CMake If you read related code, it happens when "cmake" is not...