Alessio Quaglino

Results 53 comments of Alessio Quaglino

Thanks for the revised version! My main comments are: - Why did you add so much damping to the original cable examples? - Did you try the original examples and...

Yes always run tests before committing :) For the stress visualisation, those are really good questions. I think plugins should decide what to write in your `skinuserdata` array (as you...

OK that's interesting, there is something broken with Windows then because on the main branch the dll gets copied. @saran-t what are your thoughts? As mentioned in my previous comment,...

Good point, we definitely need to fix Windows. Now I remember we disabled the test because we had some issues loading the DLL. I wonder if your change to CMakeList...

My suggestion is that we can start from the visualization PR since that doesn't requires the windows tests.

Hi @mathl79 I'm pleased to let you know that now you can run plugin tests on Windows as well, see https://github.com/deepmind/mujoco/commit/a9781d9beafd5b078538d41548065bebda6f99aa

Looks like we have to rollback the commit unfortunately, hopefully we'll be able to fix it and activate the windows tests in the next days.

Good news, Windows is fixed if you rebase from https://github.com/deepmind/mujoco/commit/043ed273a7e90d4f70cc8fcfad8d5f21ffe81eca you'll be able to run Windows tests. For the visualisation, are you going to create a separate PR from your...

Hi @mathl79 we are having a look the colouring internally (see https://github.com/deepmind/mujoco/pull/599). I wanted to ask you what is the rationale for the Von Mises stress computed directly from the...

Great to hear! Do you think you can write a unit test in `elasticity_test` comparing the reference vs computed hysteresis so any future change will make sure to not break...