Yanming Zhou

Results 241 comments of Yanming Zhou
trafficstars

Why not reuse enum.name() instead of introducing `levelName` ?

> Thanks @quaff . Any chance this gets merged? I don't know, It seems this project is not active.

> they are for a one off repository implementation rather then shared across multiple repositories? I'm trying fix it by https://github.com/spring-projects/spring-data-commons/pull/3018. > the location of the Impl class had to...

> Yeah, that's what I meant. That doesn't make sense if you want to share the fragment across multiple `basePackages`. Why not look in the same package as the interface...

> Is there a way to get a bean into the fragment? I think you want something with this declined [PR](https://github.com/spring-projects/spring-data-commons/pull/3001). But if https://github.com/spring-projects/spring-data-commons/pull/3018 is accepted, you can do like...

It should mitigate GH-3274 and GH-3307 also.

> Thank you @quaff! Would you mind adding some tests to verify the behaviour? I'm trying.

> > Thank you @quaff! Would you mind adding some tests to verify the behaviour? > > I'm trying. @christophstrobl Done!

see https://docs.jboss.org/hibernate/orm/current/userguide/html_single/Hibernate_User_Guide.html#hql-implicit-join

There is a subtle change by this PR, since implicit join will use inner join, then `IS_NULL` will require `ManyToOne` relation entity exists but property of that entity is null,...