Yanming Zhou

Results 241 comments of Yanming Zhou
trafficstars

I don't understand integration tests that you said, the commit https://github.com/spring-projects/spring-data-jpa/pull/3402/commits/ac3f8195446d1afdb450b5cc49ea96aa22b4bd18 added test to guard current behavior that deleting stale detached entity should cause optimistic lock failure.

> But it does not test what happens, when you delete a managed dirty entity. JPA will guarantee it raise `OptimisticLockException` at flush stage, I added test to cover that,...

> There is a risk that they get flushed to the database triggering life cycle events, database triggers and database constraints, while the new version won't You mentioned it already,...

It works fine with `@Bean`: ```java @Configuration static class Config { @Bean @ServiceConnection PostgreSQLContainer container() { return new PostgreSQLContainer("postgres"); } } ``` We should document current limitation and guide users...

> OK, this LGTM now. Thanks! Updated, fix that column not updated if `columnDefinition` added and differs to inferred type but the inferred type is equals to actual type in...

JDBC type names and codes are chaos, It wasted my several days, this may be my final attempt, I chose another safer way that differentiate updating from validating schema which...

It fix https://hibernate.atlassian.net/browse/HHH-18004 also.

There is a failed test `org.hibernate.orm.test.limit.Oracle12LimitTest`, but I don't think it's caused by this PR. ``` org.hibernate.exception.SQLGrammarException: JDBC exception executing SQL [select distinct p1_0.id,p1_0.name from Person p1_0 left join Person_Travel...

> If we decide to do this, we should do it in H7, not on `main` which is still H6. OK, rebased on `wip/7.0`.