Yanming Zhou comments

Results 241 comments of


                                            Yanming Zhou

trafficstars

Add `isNotThrownBy()` method as opposite to `isThrownBy()`

Do I need create a separate issue before submit PR? @scordio

Add `isNotThrownBy()` method as opposite to `isThrownBy()`

> Your intention is clear. I would like to double-check the user experience in case of errors, i.e., when the code doesn't throw anything vs. when the code throws the...

Resolve URI to baseUrl in RestClient

I agree that `URI` should be expanded also, if it's accepted for `RestClient`, then same thing should apply to `RestTemplate`, see https://github.com/spring-projects/spring-framework/pull/27188.

Ignore offset for `Limit` based query

It's not likely that Hibernate will merge proposed PR linked to https://hibernate.atlassian.net/browse/HHH-17475, I think it's better to adapt at Spring Data JPA side.

Introduce `Specification.getParameters()`

> Closing as per [#3192 (comment)](https://github.com/spring-projects/spring-data-jpa/pull/3192#issuecomment-1797953668) >> We discussed the topic as team and concluded that separation of the query and its parameters isn't a great programming model. >> >>...

Introduce `Specification.getParameters()`

> Especially `allOf`, `and` are candidates where named parameters can override each other ending up with an invalid query state. `SpecificationComposition` will deny ambiguous parameter.

Connection with active transaction returned to the pool when autoCommit=false, default schema defined and using pgjdbc

I think changing schema/catalog shouldn't be part of transaction, it should be fixed at PG side.

Connection.rollback() returns dirty connection to the pool.

https://github.com/brettwooldridge/HikariCP/blob/b40e6842080d2e7e5f8d56350aec20c49df0c9dd/src/main/java/com/zaxxer/hikari/pool/ProxyConnection.java#L392-L396 I think the `isCommitStateDirty` should be `true`.

ability to set exceptionOverride instance, not just class name

It should be covered by https://github.com/brettwooldridge/HikariCP/pull/2133.

The HikariDataSource.getConnection() method does not implement a fair borrow mechanism

>> The constructor for this class accepts an optional fairness parameter. When set true, under contention, locks favor granting access to the longest-waiting thread. Otherwise this lock does not guarantee...