Adam Byczkowski

Results 11 comments of Adam Byczkowski

Closing as #148 was merged.

Jeffs initial janky attempt. (Jeff said janky...not me!) ``` >>> classful = {8: range(0,128), 16: range(128, 192), 24: range(192, 224)} >>> i = ipaddress.ip_network("192.168.1.0/24") >>> if int(str(i).split(".")[0]) in classful[i.prefixlen]: ......

This doesn't look to be an issue anymore. ```python >>> from netutils.interface import abbreviated_interface_name >>> abbreviated_interface_name("Serial0/0/0:0") 'Se0/0/0:0' >>> ``` We also have it in the [abbreviated interface test](https://github.com/networktocode/netutils/blob/3b1004eaa66b00bf85475b3a8254c580e2a097e0/tests/unit/test_interface.py#L167)

Checked the other way too just in case. ```python >>> from netutils.interface import canonical_interface_name >>> canonical_interface_name("Se0/0/0:1") 'Serial0/0/0:1' ```

@jvanderaa I discussed this briefly with @chadell. While inventory items do provide some of the functionality of a module, the biggest difference I see missing is adding components. Inventory items...

@jvanderaa I would think we'd still keep inventory items solely based on the viewpoint Glenn pointed out [here](https://github.com/nautobot/nautobot-plugin-netbox-importer/issues/92#issuecomment-1718150685)

The error does provide two solutions. However, I'm not sure the approach you guys want to take. Let me know and I can get a PR in!

Sounds good. I will do that in the `circuit-maintenance-parser` [here](Yeah, looks like it is in the `circuit-maintenance-parser` [here](https://github.com/networktocode/circuit-maintenance-parser/blob/30095386b0a8f9558974bb45ccae6f21f21a99c8/pyproject.toml#L27C1-L27C1) since that's where it looks like pydantic is coming from.

@progala Test have been added and your suggestions committed! Let me know if those test do not suffice.

@progala Do we want to go ahead and close one due to the discussion you had with John? Sounds like we will need to rethink the approach on this so...