nautobot-app-device-lifecycle-mgmt icon indicating copy to clipboard operation
nautobot-app-device-lifecycle-mgmt copied to clipboard

Published 20 hours ago • verified publisher icon nautobot

Add additional contract type to ltm_1.6

Open qduk opened this issue 1 year ago • 4 comments

Provides the same feature as #239 but with respect to the ltm_1.6 branch. The table in the docs was using config items from Golden Config so I changed the table to match the plugin.

qduk avatar Nov 02 '23 18:11 qduk

@qduk - Thank for the updates and resubmitting this PR. Looks much better now against the ltm1.6 branch.

bradh11 avatar Nov 03 '23 14:11 bradh11

@qduk Having a second look at this I think it could be worthwile to load additional contract types from environment, see my suggestion. Could you please add tests for add_custom_contract_types?

progala avatar Jan 09 '24 14:01 progala

@progala Test have been added and your suggestions committed! Let me know if those test do not suffice.

qduk avatar Jan 11 '24 15:01 qduk

@progala Do we want to go ahead and close one due to the discussion you had with John? Sounds like we will need to rethink the approach on this so it propagates everywhere a new contract type would be needed.

qduk avatar Feb 27 '24 23:02 qduk

Closed as agreed. New approach is needed.

progala avatar Jul 25 '24 15:07 progala