Mozi

Results 112 comments of Mozi

Hi. > ... This caused a failure on my application because the earlier code wouldn't set the PLATFORM variable, but the new code does (it would set it in a...

@ilammy Thank you for explanation. But sorry, I still can't get the point. v1.7.0 also exports `Platform` , right? Why @abellgithub 's build passed when using v1.7.0 ?

@abellgithub Thank you for posting the actions. I've noticed that the uppercased `PLATFORM` variable. And, finally, I figured out why v1.7.0 works fine. I want to put my analysis here....

Hi, @coder3101 . > Say 14.25 on windows-2019 image is no longer present. Good news: the toolset 14.25 has been back on 1 July 2020. See https://github.com/actions/virtual-environments/pull/1146 .

Hi, @kwhat . > Seems to only fail after the second usage, order doesn't appear to matter. Thank you for posting the screenshot of the log. Let's focus on these...

> GitHub should provide a way to opt out of automatically closing issues mentioned in a PR Well, you used the ["Resolves" keyword](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) to link this issue with that PR,...

> There is a list of linked PRs and issues, but it's not possible to “uncheck” things there to prevent automatic closure. Indeed. We can only use "plain" references like...

> GitHub Actions don't have an ability to remove a variable for further steps What if we set the value of those variables to empty?

@ajfriend Hi. The action [microsoft/setup-msbuild](https://github.com/microsoft/setup-msbuild) is used to find the parent directory of MSBuild.exe by calling [vswhere.exe](https://github.com/microsoft/vswhere) ([source code](https://github.com/microsoft/setup-msbuild/blob/2008f912f56e61277eefaac6d1888b750582aa16/src/main.ts#L16-L24)). It has nothing to do with the MSVC toolset. The `vs-version`...

More info: For the MSVC toolset, Visual Studio 2019 supports up to v142, while Visual Studio 2017 only supports up to v141. If you want to use MSVC v142 with...