Pedro Alcantara
Pedro Alcantara
@luccosta I think we can do this way because the functions need to be added in both classes anyway, so I don't think that is reworked, let's do this way...
@chapulina Thank you How about the size of each PR, one for each function is too small, or is ok? Since will have the function implementation and the Unit test...
@chapulina, here it goes the first small PR, how about the size, too small? The link of the **contributing.md** is off so I have no reference. To continue the implementations...
Ok, It sounds good but, what I meat about the implementation of `Normalize()` is that, in Vector3 it `return` a copy of the object and in Vector3 it is `void`...
> Oh yes, I looked too quickly and didn't notice that. There's an issue for that, #34 . I think it can be considered out of the scope for this...
Now I'm gonna work in the functions: ``` - Max(const Vector3 &_v) - Min(const Vector3 &_v) - Max() - Min() ```
> In research I found that `Cross` product only exists in 3 or 7 dimensional vectors, and `Perpendicular` has a different meaning in 4 dimensions, so I was thinking in...
Hi @akshatpandya Really nice. I the beginning of the post there is a list of functions that should be implemented from Vector3 to Vector4 class. I think you can start...
@akshatpandya Apparently the functions are already implemented in Vector4, [here](https://github.com/ignitionrobotics/ign-math/issues/71#issuecomment-653032394), so, would be better to work on Vector2 [list](https://github.com/ignitionrobotics/ign-math/issues/71#issuecomment-652695150)
@akshatpandya Saturday will happen this [event](https://community.gazebosim.org/t/hacktoberfest-ignition-meetup-the-d-day/698/2) to collaborate together with the Ignition. It'll be really nice to see you there :+1: