Vitaly Puzrin

Results 331 comments of Vitaly Puzrin

@rbuels look at this lines: https://github.com/nodeca/pako/blob/c60b97e22239c02c0b5a112abbd6c6a9b5d86b45/lib/inflate.js#L279-L281 It seems, this should be removed, because Z_STREAM_END is processed inside loop and should not finalize deflate. But after removing that line, one test...

@bovee I'll be happy to accept correct PR. As far as i remember, #145 was rejected because touched original `zlib` content (see my comment). @Kirill89's fix was correct in general,...

https://github.com/nodeca/pako/commit/e61498ca597e885308cbe8c3c0eafcd873e78b63 I've rewritten wrappers. hose works with our old multistream fixture, and with data generated with Z_SYNC_FLUSH. But still fails with provided bgzip file, now with `invalid distance too far...

@drtconway wrapper changed significantly but multistream test exist https://github.com/nodeca/pako/blob/0398fad238edc29df44f78e338cbcfd5ee2657d3/test/gzip_specials.js#L60-L77

@Pomax @mdmoreau could you comment SVG use cases? I'm designing SVG support API, and not sure that mixing floats & ints is good idea https://github.com/nodeca/probe-image-size/issues/4. - usually people expect that...

I've seen your commit, and asked questions after that. 1. Your PR makes api good for you, but less comfortable for those who don't use SVG (but can have it...

@mdmoreau I agree, if use-case is "keep aspect ratio", then units are not needed. Need to understand if there are other cases, where lack of units can become a problem....

@Pomax if we speak about existing `image-size` library - no question, your change will not break compatibility. Because you can say that SVG can be detected with invalid units. If...

SVG support is now available in https://github.com/nodeca/probe-image-size. With floats, units info etc.

@zeke thanks, updated :) . I hope code quality is high, but still interested in massive feedback.