Vitaly Puzrin

I do not like to accept changes "just for fun". Please, explain the reasons first, why this is not opinion-based and could be useful for all. As far as I...

https://github.com/puzrin/dispenser/blob/master/support/build_fonts.js#L28 Output is not related to input, custom names are ok.

Ah, ok. Now understand. May be reasonable. But note, that's lvgl-writer specific. Binary output has no such need. Could you suggest an argument name, "lvgl-specific"?

Also, test helper probably should align OS codes (for gzip) before compare https://github.com/nodejs/node/pull/10980#issuecomment-316865333. That does not make sense now, but may be useful for others.

UPD: it seems that zlib 1.2.11 really changed deflate `stored` binary representation ```js const pako = require('pako'); const zlib = require('zlib'); const fs = require('fs'); const assert = require('assert'); const...

@rbuels just remove those lines and you will see.

Ups... sorry, wrong comment. Yes, that's still an issue. But it's better so solve it as part of resync with upstream. That's a separate task

Can this be a dupe of https://github.com/nodeca/pako/issues/174#issuecomment-535347692 (header set wrong window size)?

It's a problem to make wrapper universal. v2 closed many other dirty cases. If you have time, i'd suggest to inspect node.js wrapper for zlib - https://github.com/nodejs/node/blob/master/lib/zlib.js - https://github.com/nodejs/node/blob/master/src/node_zlib.cc May...

See https://github.com/nodeca/pako/issues/234#issuecomment-887096829 v2 changed wrapper to "standard one", according to zlib docs. v1 terminated process on sync mark, that caused problem with multistream files. v2 does NOT emit end on...