Vitaly Puzrin

Results 331 comments of Vitaly Puzrin

This is bug in superagent, https://github.com/visionmedia/superagent/issues/1577

Seems node 14 fixed. I have no this problem anymore.

2c: - see [pledgie campain](https://pledgie.com/campaigns/15816) of ttfautohint. It cost nothing to try do the same. Just show a clear goal to reach and what you can suggest for next milestone....

We need do discuss final data format in original issue. I don't like duality (null & undefined) for single case, especially when it's hidden behind api call.

> I'm okay with just checking against `undefined`, but that would mean that doing `.setAttrs('attr', null)` -> `attr="null"` is expected behavior. > > Let me know what you decide and...

https://github.com/markdown-it/markdown-it/blob/master/lib/renderer.js#L177 You may override attrs renderer to support empty values.

That's strange - nobody asked such feature for 5 years. But i have no principal objections.

I'd suggest use notation `attrSet('download')`, it's clear. Also, i'd avoid use attrSet for unsetting and any kind of unsetting in our api at all.

> Besides, the access control on `Token` should be reinforced. Guarantees of 100% validate-able html are out of scope. If using `.attr*` methods, user is expected to understand well what...

I think that may be a bug. Usually only top level blocks are used to sync with preview scoll. So, nobody checked what happens in lists. But i don't remember...