Pushkal Katara
Pushkal Katara
Hi @nsjcorps You need to create a token file and enter a valid token in it while the test `setUp` and remove the token while test `tearDown`.
Hi @Rithi-21 Can you please also fix coverage as the part of the build by writing the tests.
Hi @Rithi-21 Still the coverage is not fixed. It lacks by 0.9%. Please resolve the issue.
Hi @Rithi-21 The PR now look fixed, please reclaim the GCI issue so that we can approve it, as we can see you have abandoned it recently.
Nice work @nsjcorps, Looks good to me too.
@daniel22373 @m-sameer The task is to use 2 as the wrapper for 1. Rename the file get_token.py to token.py and use the utils to write a click wrapper for get_token...
@m-sameer Click defines decorators for each function to be used as a CLI command. In order to seperate click decorators and implementation of the function, we have two files token.py...
1. Rename get_token.py -> auth.py 2. Import utils/auth.py in auth.py 3. update get_token function to use functions present in utils/auth.py 4. Check if the function works well 5. Post screenshots...
Yes, you can choose either of them.
Looks good to me. @Ram81 let's approve this?