Puneet Lath

Results 188 comments of Puneet Lath

Nice! Sounds good. Perhaps we should break it up into a few different PRs so that it's easier to revert if one of them causes a problem, without needing to...

Ah interesting. Let me see if I can find any place where they get set from the back-end.

I don't see `report.errors` or `report.displayName` as being returned from the back-end anywhere. So I think it should be safe to remove. Do you agree @shubham1206agra? Also, @TMisiukiewicz do we...

@TMisiukiewicz I see in this PR a bunch of these keys getting re-added to the report type: https://github.com/Expensify/App/pull/50745/files Can we please add a unit test that tests that only the...

@ZhenjaHorbach @lakchote do we need regression tests for this?

Looks like no Upwork job was every created. @hoangzinh @ZhenjaHorbach can you ping me on this issue when you've accepted these offers? @hoangzinh https://www.upwork.com/nx/wm/offer/104700848 @ZhenjaHorbach https://www.upwork.com/nx/wm/offer/104700852

I actually saw that @MonilBhavsar is removing these violations from being returned to NewDot [here](https://github.com/Expensify/App/issues/52748). So in that case, I think we can just remove them from CONST.ts altogether and...

Going ahead and making this external. A contributor should be able to help us add support for the `REIMBURSED` reportAction in NewDot.