[HOLD for payment 2024-12-17] [LHN Mismatch] Move client-only keys from report_ to reportMetadata_

[puneetlath]

We are going to be changing the behavior of OpenApp/ReconnectApp when it does a full reconnect to replace the full reports list that the client has stored instead of merging with it. This means that any client-only data that we have about reports can potentially get wiped when the back-end reconnects.

We already have a reportMetadata_ object in Onyx that is meant to store such data. Let's move any keys that are currently client-only that are stored in the report_ object to the reportMetadata_ object. These are some likely keys that we will need to migrate:

1. avatarFileName: The filename of the avatar.
2. icons: List of icons for report participants.
3. isPolicyExpenseChat: Indicates whether the report is a policy expense chat.
4. lastMessageTimestamp: The timestamp of the last message on the report.
5. lastReadCreated: The time of the last read of the report.
6. openOnAdminRoom: If the admin room should be opened.
7. cachedTotal: Report cached total.
8. lastMessageTranslationKey: Translation key of the last message in the report.
9. isOptimisticReport: Whether the current report is optimistic.
10. displayName: Display name of the report, shown in options and mentions.
11. ownerEmail: E-mail of the report owner.
12. errors: Collection of errors to be shown to the user.
13. isLastMessageDeletedParentAction: Whether the last message was a deleted parent action.
14. iouReportAmount: Total amount of money owed for IOU report.
15. preexistingReportID: The ID of the preexisting report.
16. isHidden: Whether the report is hidden from the options list.
17. isChatRoom: Whether the report is a chat room.
18. participantsList: Collection of participants' personal details.
19. text: Text to be displayed in the options list, which matches reportName by default.
20. privateNotes: Collection of participant private notes, indexed by their accountID.
21. isLoadingPrivateNotes: Whether participants' private notes are currently loading.
22. selected: Whether the report is currently selected in the options list.
23. pendingChatMembers: Pending members of the report.
24. transactionThreadReportID: The ID of the single transaction thread report associated with this report, if one exists.
25. participantAccountIDs: Participant account IDs.
26. visibleChatMemberAccountIDs: Visible chat member account IDs.

To do this we will need to:

1. Confirm whether this is the complete list of keys to migrate or whether there are others
2. Confirm whether these keys all need to exist. Some of them seem like they might potentially be redundant and could be removed altogether. For example, isPolicyExpenseChat and isChatRoom seem like they may be redundant with chatType. The ownerEmail seems like it may be redundant with ownerAccountID. We should check each key and ensure that it's actually needed.
3. For those that are needed, let's move them to reportMetadata_ by: a. Updating any code that sets the data to set it in reportMetadata_ instead b. Updating any code that gets the data to get it from reportMetadata_ instead c. Create migration to migrate any existing data in these keys from report_ to reportMetadata_
4. Let's make it so that people can't accidentally add new client-only keys to the report object. We can do this by adding a unit test that checks that only these keys have been added to the report object. So that it must be explicitly updated if new keys are added after confirming that they are safe to add there

Issue Owner

Current Issue Owner: @muttmuure