App icon indicating copy to clipboard operation
App copied to clipboard

[HOLD for payment 2024-10-24] [Wave Control] [QBD] [Export] Preferred exporter page

Open lakchote opened this issue 1 year ago • 13 comments

Will be worked on by an external contributor (see https://expensify.slack.com/archives/C03SLTAEULW/p1726876645021139).

Design doc link: https://docs.google.com/document/d/1LQNlTBlHjFqRdru_4UkqVr0QRseNNDq2IhFFpXcgfwY/edit#bookmark=id.v3esmouhfimf

lakchote avatar Sep 25 '24 13:09 lakchote

Still on hold for #49697.

lakchote avatar Oct 07 '24 09:10 lakchote

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Oct 17 '24 01:10 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.49-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/50297

If no regressions arise, payment will be issued on 2024-10-24. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @hoangzinh requires payment (Needs manual offer from BZ)
  • @ZhenjaHorbach requires payment (Needs manual offer from BZ)

melvin-bot[bot] avatar Oct 17 '24 01:10 melvin-bot[bot]

@lakchote I think we need to add somebody from BZ team here !

ZhenjaHorbach avatar Oct 24 '24 11:10 ZhenjaHorbach

Issue is ready for payment but no BZ is assigned. @puneetlath you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

melvin-bot[bot] avatar Oct 24 '24 18:10 melvin-bot[bot]

Payment Summary

Upwork Job

  • ROLE: @hoangzinh paid $(AMOUNT) via Upwork (LINK)
  • ROLE: @ZhenjaHorbach paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@puneetlath)

  • [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • [ ] I have verified the payment summary above is correct

melvin-bot[bot] avatar Oct 24 '24 18:10 melvin-bot[bot]

@ZhenjaHorbach @lakchote do we need regression tests for this?

puneetlath avatar Oct 25 '24 14:10 puneetlath

@puneetlath, @hoangzinh, @lakchote, @ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Oct 28 '24 18:10 melvin-bot[bot]

@ZhenjaHorbach @lakchote do we need regression tests for this?

@puneetlath

I think it will be useful !

Regression Test Proposal

  • Sign in on an account above
  • Connect your workspace to QBD
  • Set multiple admins for your workspace
  • Go to Accounting
  • Click on "Export" menu under QuickBooks Desktop connection
  • Click on Preferred exporter
  • Verify that there is a list of admins on the screen and after selecting one of them, it becomes the current exporter

Do we agree 👍 or 👎

ZhenjaHorbach avatar Oct 28 '24 18:10 ZhenjaHorbach

@ZhenjaHorbach @lakchote do we need regression tests for this?

Yes! QBD regression tests will be added centrally.

An issue has been created for it.

lakchote avatar Oct 29 '24 10:10 lakchote

@puneetlath, @hoangzinh, @lakchote, @ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Nov 01 '24 18:11 melvin-bot[bot]

Looks like no Upwork job was every created. @hoangzinh @ZhenjaHorbach can you ping me on this issue when you've accepted these offers?

@hoangzinh https://www.upwork.com/nx/wm/offer/104700848 @ZhenjaHorbach https://www.upwork.com/nx/wm/offer/104700852

puneetlath avatar Nov 01 '24 19:11 puneetlath

Looks like no Upwork job was every created. @hoangzinh @ZhenjaHorbach can you ping me on this issue when you've accepted these offers?

@hoangzinh https://www.upwork.com/nx/wm/offer/104700848 @ZhenjaHorbach https://www.upwork.com/nx/wm/offer/104700852

Done Thanks !

ZhenjaHorbach avatar Nov 02 '24 08:11 ZhenjaHorbach

@ZhenjaHorbach paid. Just waiting on @hoangzinh now.

puneetlath avatar Nov 02 '24 17:11 puneetlath

Accepted. Thanks @puneetlath

hoangzinh avatar Nov 03 '24 09:11 hoangzinh

All paid. Thanks y'all!

puneetlath avatar Nov 04 '24 17:11 puneetlath

@puneetlath @lakchote Be sure to fill out the Contact List!

melvin-bot[bot] avatar Nov 04 '24 17:11 melvin-bot[bot]