Peter Taoussanis

Results 575 comments of Peter Taoussanis

Hi @sskorokhodov, not sure I completely understand your question. Could you please include an example of what you've already tried, and what's not working the way you'd like? Thanks!

> If the body is empty, the response will have Content-Length set to 0, overriding the user-provided value. Okay, gotcha- thanks for clarifying! That sounds like a bug to me...

As documentation, noting association with https://github.com/http-kit/http-kit/issues/127

Re-opening since a proper fix will require further thought. Basic problem is this: - Current versions of http-kit server intentionally ignore custom content-length headers (see #127). - Seems like there...

Would be happy to take a look at a minimal reproducible example if someone could please provide one 👍

@MokkeMeguru Hi Mokke! Would please request a smaller reproducible example without the use of a framework, or so many dependencies and namespaces. If there's a fundamental problem with sessions during...

@zgtm Thanks for the report, and your investigation! Just adding for context: the `sentContinue` flag does appear to be non-functional as currently implemented. Flag was introduced with https://github.com/http-kit/http-kit/pull/130. Looks like...

From a very quick skim of the code, it looks like we might be able to move the `sentContinue` state to either the `HttpRequest` or `HttpDecoder` class (where `requiresContinue` is...

PR looks good, thanks @zgtm! No obvious idea off-hand for the tests, sorry. Haven't had a chance to look in detail though. I'll merge the fix into the current snapshot...

Update: looks like `org.httpkit.server-test` might be a reasonable place for tests- there's some tests in there that seem fairly close to what we'd need?