Peter Taoussanis

Results 575 comments of Peter Taoussanis

Hi there, PR very welcome to adjust default max and error resp to match nginx behaviour!

> Is that a correct reading of the code? Yes, I believe that's all correct as per the current implementation. Semantically, the timeout _appears_ to be intended to function as...

Have added a [TODO](https://github.com/http-kit/http-kit/blob/bdbb2b1134350064c46376bb02ef97a94b4c47b6/src/java/org/httpkit/client/HttpClient.java#L190) in the interests of consistency. PR welcome if anyone felt like tackling this!

Noting similarity to https://github.com/http-kit/http-kit/issues/361 Anyone want to take a look at the [fix](https://github.com/http-kit/http-kit/commit/af5ef4a8c758d2be05259666479d82cb2884e41b) for #361 and see if it might be helpful here somehow?

Hi Bill, have you tried checking for possible dependency conflicts and cleaning out build artefacts?

@tweeks-reify Hi there, thanks for this! While I agree that "should not happen" is too vague, I wonder if we could maybe do even better than "investigate this error"? What...

@tweeks-reify That sounds reasonable to me 👍 So "http server loop error, see stack trace for details"?

👍 Will merge for v2.7 next time I'm doing batched work on http-kit - thanks!

Merged manually, closing 👍