René Widera

Results 480 comments of René Widera

@MSVoss Sry for the late response, there is only one open question before we can merge this code.

The CI is unhappy :-( there are some style issues in the py files.

I will do the last review this week.

@MSVoss ~~could you please check the following formating/import issues~~ The formatting issue is in the third-party folder, please rebase your PR against the latest dev to solve the problems.

@MSVoss thx for the updates, from my side all, looks fine! @steindev @PrometheusPi could you please recheck this PR again until tomorrow so that we can merge it soon?

@Anton-Le I beautified your nice PR description, you can render latex in Github: https://gist.github.com/a-rodin/fef3f543412d6e1ec5b6cf55bf197d7b

> typename PICToSplash::type radSplashType Please link the code you mentioned `typename PICToSplash::type radSplashType`

> @psychocoderHPC Is it possible to parametrize the data type (here `float_64`) of the `typename PICToSplash::type radSplashType;` in `Radiation.hpp` to always be determined by the type of of the data...

@Anton-Le Could you please rebase this PR against the dev branch.

> I think the proposed changes in this PR seem very reasonable and do not require changing that many places in the code, so nothing against it. The following is...