René Widera

Results 480 comments of René Widera

@BrianMarre do you see whats wrong here? Why is pypicongpu crashing during the compile? https://gitlab.com/hzdr/crp/picongpu/-/jobs/7408406476

> @BrianMarre do you see whats wrong here? Why is pypicongpu crashing during the compile? > > https://gitlab.com/hzdr/crp/picongpu/-/jobs/7408406476 Maybe it took so long because we can not set `pic-build -j`...

this PR is replaced by many others where the ID generator is given to each particle creation kernel therefore we can close this PR

> Looks okay to me. In contrast to my version, you've only got 2 calls to `tryCleanPage` when it's 4 in my case. One of them is when trying out...

I checked if `tryCleanPage` is called where it should The multi page allocation for large chunks is not using the fill level. It uses the chunksize only therefore `tryCleanPage` is...

@franzpoeschel ~I am wondering why there are toml changes in this PR, I thought it is about json only?~~ https://github.com/ComputationalRadiationPhysics/picongpu/pull/5367#issuecomment-2908983679 explain my question

@franzpoeschel could you commit the toml and json update as generic user ``` GIT_AUTHOR_NAME="Third Party" GIT_AUTHOR_EMAIL="[email protected]" git commit ``` and all cmake changes within a seperate commit.

why do we not use the openPMD shipped json library if a target `nlohmann_json::nlohmann_json` is already available? Let's discuss it in our next developer meeting.

@franzpoeschel You set the toml and lohmann json developer as auther. I thought about is. We should not do that. We should them set as co-auther and commit as tools...

I like the idea. I am not sure if I would invest time into a bot. The reason for it is that the bot must run somewhere and it is...