ComputationalRadiationPhysics
KHI_growthRate Testsuite
Integrate the test suite that compares the growth rates for the Kelvin Helmholtz instability setup
The python scripts are not pep8 formated: https://gitlab.com/hzdr/crp/picongpu/-/jobs/2453910558 All python scripts need to pass pep8 code style checks and flake8 checks.
I had a brief discussion with @psychocoderHPC:
Please transfer the code from the *.tpl that runs the test to a test script validate.sh that returns 0 in case of passing and 1 in case of not passing the growth rate test.
A second program called ci.sh should first run PIConGPU directly from the command line picongpu -d 1 1 1 -g ... -s ... ... as in your submit.start files and the call validate.sh.
Both scripts should be included in a bin directory inside your test directory.
The reason for the separate ci.sh file is, that our GPU based test system does not have (yet) a scheduler and thus will run PIConGPU and later the test as in a regular script.
We can discuss details in person after your lecture if you have time.
@MSVoss Could you please squash your PRs into two single commits? One commit with the python stuff and one with the next ample.
sry for the late review I was always looking if the tpl files are already removed and thought the PR is not updated because the file was still in.
@MSVoss Sry for the late response, there is only one open question before we can merge this code.
I don't think that every single test case needs its own structure. However, with each new test case, I work out a generalization of the test suite. In the new test case, which I'm working on now, some classes are renamed and generalized.
I hope I've corrected everything except for the documentation
Documentation is left for a separate PR?
I hope I've corrected everything except for the documentation
Documentation is left for a separate PR?
Yes
@MSVoss I checked all comments and marked those as resolved that I could evaluate. There are only a few missing that you need to check back. I believe we discussed last week something that has not been mentioned here. But I cannot remember what it was. If you do not remember as well or do not know what I mean than we will just merge.
@MSVoss ~~could you please check the following formating/import issues~~
The formatting issue is in the third-party folder, please rebase your PR against the latest dev to solve the problems.
@MSVoss thx for the updates, from my side all, looks fine!
@steindev @PrometheusPi could you please recheck this PR again until tomorrow so that we can merge it soon?