Piotr Sarna

Results 123 comments of Piotr Sarna

Hi, I'm from ScyllaDB, but this post is from my private spare time, so no warranty :) I stumbled upon this issue while lurking for places to learn Rust from,...

Also, as an exercise for myself, I wrote a quite useless (at least for now) snippet that reads Scylla sharding info from a node and prints it: https://github.com/psarna/cdrs/commit/1b25affc7d1360e9fec441f907c8846ada27ed2b. Perhaps it...

Thanks. I'm a little short on time, but I'll try to figure out Rust's conditional compiling by myself, and perhaps one day I'll push something more substantial. And if token-aware...

Note that setting a value or exception on a promise that already has it will trigger an assertion, so it's not hard to see that your code doesn't work and...

Isn't the test case subject to races? The clock action is async, and you're not really waiting for any pending tasks to be cleared from the reactor before it finishes....

Regular periodic seastar timers would work the same way - if for any reason the periodic action didn't fire for 30 seconds, it won't catch up by firing itself 29...

I vaguely remembered that we had similar issues already, but the only related one I found was https://github.com/scylladb/scylla/issues/3902

And to answer your question about wasting work - when fixing filtering + limit in 2018 we also had a similar discussion, and ended up in trimming the results in...

> > It should be easy to just ignore the LIMIT in the first stage. > > Unfortunately it's not easy. I modified the first part (reading the index table)...

@piodul fyi, could you try evaulating whether the fixes you considered as follow-ups for https://github.com/scylladb/scylladb/pull/11166 are related and could address this problem as well?