Piotr Sarna

Results 123 comments of Piotr Sarna

Splendid, thanks guys! 1.8MiB sounds way more aligned with edge use cases indeed, will give it a try

v2: - .wat source code is now precompiled to a wasm module during initialization, once - each valid wasm function is now dynamically registered as a user-defined function, so it's...

v3: - multiple fixes - added CREATE FUNCTION statement - added DROP FUNCTION statement TODO: - [x] automated tests - [x] docs

@penberg please don't merge just yet as it needs more quality Rust tests, covering all types and so on, but I'm marking this PR as ready for review, because the...

@penberg I added a few more tests, I'm yet to produce docs (mentioning that the thing is experimental), but code review is welcome!

self note: there's a spontaneous double free caused by dropping a wasm function, will investigate tomorrow

(false alarm, the bug was in the tests)

I added an initial doc explaining Wasm functions and configuration

todo based on manual tests: CREATE FUNCTION should accept not only strings, just expressions - that would allow using `readfile` for uploading large .wat files

Another todo: we should seriously consider switching to storing raw .wasm binary blobs exclusively, or at least add such support next to .wat files. Wat files are human readable and...