xls icon indicating copy to clipboard operation
xls copied to clipboard

Define an object for collecting DSLX interpreter events.

Open meheff opened this issue 3 months ago • 6 comments

The newly defined DslxInterpreterEvents gathers assert and trace messages from the DSLX interpreter replacing the previous trace hook mechanism. It stores information in the same proto as the IR interpreter does which enables easier comparison of behavior between the interpreters and the sharing of tools. Also augment the proto with additional information like source information.

Also add a utility dump_call_trace which reads an events proto and prints a structured trace of the calls.

meheff avatar Sep 12 '25 20:09 meheff

Any progress on this? Thanks.

meheff avatar Oct 15 '25 15:10 meheff

@richmckeever: ping for review ? adding @cdleary too.

proppy avatar Oct 15 '25 15:10 proppy

@meheff Please rebase this when you can; we can't pull it in for final review until conflicts are resolved.

ericastor avatar Oct 29 '25 13:10 ericastor

Rebased to head... and changed my notifications for the XLS repo to my personal email account as I kept missing responses on my PRs (my work email might as well be /dev/null).

meheff avatar Nov 05 '25 22:11 meheff

@meheff sorry, I missed this. Can you please add Apache license headers? The migration is failing with:

error: Error validating 'verify_match 'Licensed under the Apache License, Version 2.0'': xls/dev_tools/dump_call_trace.cc - Expected string was not present.

Error validating 'verify_match 'Licensed under the Apache License, Version 2.0'': xls/dev_tools/dump_call_trace_test.py - Expected string was not present.

mikex-oss avatar Nov 07 '25 22:11 mikex-oss

Added licenses.

meheff avatar Nov 07 '25 23:11 meheff

@meheff did you get a change to look at @mikex-oss comments?

proppy avatar Dec 24 '25 02:12 proppy

this also need to be rebased.

proppy avatar Dec 24 '25 06:12 proppy