Define an object for collecting DSLX interpreter events.
The newly defined DslxInterpreterEvents gathers assert and trace messages from the DSLX interpreter replacing the previous trace hook mechanism. It stores information in the same proto as the IR interpreter does which enables easier comparison of behavior between the interpreters and the sharing of tools. Also augment the proto with additional information like source information.
Also add a utility dump_call_trace which reads an events proto and prints a structured trace of the calls.
Any progress on this? Thanks.
@richmckeever: ping for review ? adding @cdleary too.
@meheff Please rebase this when you can; we can't pull it in for final review until conflicts are resolved.
Rebased to head... and changed my notifications for the XLS repo to my personal email account as I kept missing responses on my PRs (my work email might as well be /dev/null).
@meheff sorry, I missed this. Can you please add Apache license headers? The migration is failing with:
error: Error validating 'verify_match 'Licensed under the Apache License, Version 2.0'': xls/dev_tools/dump_call_trace.cc - Expected string was not present.
Error validating 'verify_match 'Licensed under the Apache License, Version 2.0'': xls/dev_tools/dump_call_trace_test.py - Expected string was not present.
Added licenses.
@meheff did you get a change to look at @mikex-oss comments?
this also need to be rebased.