client_golang

client_golang copied to clipboard

Go metrics go_memstats_alloc_bytes and go_memstats_alloc_bytes_total collide in OpenMetrics and are still both exposed

12

I received a bug report https://github.com/caddyserver/caddy/issues/3940 which seems to be caused by 2 metrics exposed by the Go collector: `go_memstats_alloc_bytes` and `go_memstats_alloc_bytes_total` - in effect, these names seem to be...

hairyhenderson

Consider (optionally?) enforcing certain metric naming conventions

5

Hi, I think it makes sense to have this verification on client-side in official Prometheus library - some rules are must-have like `_total`. I guess the problem is how to...

bwplotka

Consider SummaryVec and HistogramVec methods to return concrete types rather than Observer/ObserverVec, or merge Summary and Histogram into one type

2

When applying labels to SummaryVec or HistogramVec, a "generic" Observer interface is returned. This is inconsistent with other *Vec types and does not appear to serve any useful practical purpose....

oakad

OpenMetrics has the option of marking creation times of metrics. As this doesn't happen as part of some 1st class metadata but as an additional time series with a magic...

beorn7

OpenMetrics unit support (in v1)

7

OpenMetrics offers units as part of the metadata. We can easily add them in the various `...Opts` next to `Help`. They would only be used if OpenMetrics is negotiated as...

beorn7

OpenMetrics names counters without the `_total` but adds the suffix in the metricname. We need to come up with certain compatibility modes, configurable somewhere. TODO: Copy the thoughts from me...

beorn7

Remove namespace/subsystem

8

They are internally concatenated to a plain metric name. The protobuf, which is always mentioned as the canonical representation of a metric, doesn't support it either. It's also an arbitrary...

fabxc

Consider not having channels in the Collector interface

13

This is the current `Collector` interface: ``` type Collector interface { Describe(chan

beorn7

Add test tools based on the new type structure

3

Once #223 is done, we can make use of it for better testing tools (like mocking helpers for the various interfaces we end up with).

beorn7

Rework Desc and ConstMetrics

4

- Desc needs to also include bucket layout and type. - Desc creation needs to be easier. Consider creating a Desc from an Opts instance, give it a Desc() method....

beorn7