client_golang

client_golang copied to clipboard

Consider more efficient protobuf implementations

10

Since we will have significant breaking changes in 0.10, this is a good time to consider using https://github.com/gogo/protobuf instead of the current stock protobuf implementation. In high frequency scrape scenarios,...

beorn7

OpenMetrics info type (in v1)

1

OpenMetrics makes the `..._info` metric pattern explicit as its own type. In v1, we can add the type and emulate it for the existing Prometheus format by creating the usual...

beorn7

Easy way to initialize counter vecs?

6

See code like https://github.com/prometheus/prometheus/blob/b0adfea8d5e883cbab5c7e4113f8ea91f7cbc099/rules/manager.go#L75-L78 . If you know in advance all the values each label can take, it is recommended to initialize all combinations so that each possible counter is...

beorn7

Vec and non-Vec cumbersome to use

12

I just run into a case again where we have a bunch of plain counters and summaries, which now should have a label attached. From our data model a metric...

fabxc

Handle query parameter of a scrape

6

A prerequisite to #135, this is about the story how to handle scrape query parameter in general. This should help to implement the blackbox exporter in a cleaner way, cf....

beorn7

Detect name collisions around _bucket, _count, _sum, and the quantile label during registration

3

~~With~~ Once #222 is done, we can ~~now~~ then detect above mentioned collision during registration time. See #108 for more details.

beorn7

Consider optional disabling of metric sorting

3

With extremely large exposition (example: kube-state-metrics on a large cluster will expose hundreds of MiB of metrics data), sorting of metrics becomes a quite significant computational burden. As metrics sorting...

beorn7

Consider partitioning InstrumentHandlerInFlight middleware by method

1

Then it would accept a GaugeVec which might or might not have a method label (but no others). It would break the fairly frequent use of this middleware. Thus, it's...

beorn7

Consider eliminating MustRegister, moving global registry to promauto.

2

With the additions to the promauto package in #713 , the need for `MustRegister` is diminished: Whoever doesn't care about panicking, can and should use `promauto` constructors, no matter if...

beorn7

More powerful and more customizable MultiError

4

The ad-hoc `prometheus.MultiError` implementation doesn't support the new goodies from the standard `errors` package. It also formats into a multi-line error string, which is undesired by some users. Both could...

beorn7