client_golang icon indicating copy to clipboard operation
client_golang copied to clipboard

Published 20 hours ago • verified publisher icon prometheus

OpenMetrics unit support (in v1)

Open beorn7 opened this issue 6 years ago • 7 comments

OpenMetrics offers units as part of the metadata. We can easily add them in the various ...Opts next to Help. They would only be used if OpenMetrics is negotiated as the output format (but they will also implicitly show up in protobuf, cf. https://github.com/prometheus/common/issues/214 ).

beorn7 avatar Nov 28 '19 13:11 beorn7

Hello, I'd like to work on this issue

vesari avatar Nov 20 '23 10:11 vesari

/cc @bwplotka @kakkoyun

beorn7 avatar Nov 21 '23 10:11 beorn7

Totally, I am supportive. Help wanted @vesari 😊

bwplotka avatar Nov 21 '23 12:11 bwplotka

Hello, I'd like to work on this issue

Let us know if you need any assistance :)

ArthurSens avatar Nov 21 '23 13:11 ArthurSens

Great! I'm on it :)

vesari avatar Nov 21 '23 13:11 vesari

@bwplotka @ArthurSens I've opened my first PR in solving this issue: https://github.com/prometheus/client_model/pull/75. Can you please take a look? I'm also opening PRs in prometheus/common and prometheus/client_golang but they both depend on the former.

vesari avatar Dec 02 '23 15:12 vesari

Just noticed that Björn was quicker than us with the client_model PR. Feel free to directly ping me in the prometheus/common PR if you need reviewers, I don't receive notifications for that repository 😬

ArthurSens avatar Dec 06 '23 21:12 ArthurSens