Patrick Riley

Results 69 comments of Patrick Riley

So a few comments after reviewing this some... 1. This one seems possible but I'm not sure if we should structure navigation header tabs in the same component (or it...

So after discussing w/ @jgiardino a bit further, it seems we'd like to make a distinction between the tab elements themselves (rendered as `ul`s and `li`s) and the tab content...

good points @cdcabrera ... so i guess the primary goal is making the html more semantic (removing `divs`) where we can (and [sexy](https://www.html5rocks.com/en/tutorials/webcomponents/customelements/) according to Eric Bidelman). The `pf-tabs` element...

started #67 to address this issue... will resolve there.

I would agree with this. In many scenarios defining a custom element in js is useful (say you want to define a callback method or call a method on initialization...

is there a change you'd like to contribute? I'm not sure what's necessary here - an addition in the gulpfile to warn them?

I'll be writing some more examples of this soon and will try to reference this issue.

I agree that node4/node6 errors are not as indicative as they should be. I've just gotten used to seeing es6 things like `const` and knowing it may be a node...

Not sure I follow the issue here...can you provide a description @dtaylor113 ?

hey @spencermountain - in relationship to this issue, wanted to quickly ask if you can think of any easy methodology or option to remove periods from the `.people()`, `.places()`, `.organizations()`...