Patrick Riley

Results 69 comments of Patrick Riley

@agathver I'd be curious what our minimum browser support is with/without asynchronous loading. I can do some browerstack testing if you can open a separate PR with the change? We...

it should be noted that [PF5](https://github.com/patternfly/patternfly-css) is using SASS, so our future Bootstrap 4 port will use SASS. So I'm not sure how significant this is at this point. @bleathem...

@agathver this PR looks excellent to me. Major kudos for getting this done so quickly, making the code concise, and showing all the different use cases. @cdcabrera do you mind...

So with the existing Bootstrap Switch, the current rendered DOM structure looks something like this: https://rawgit.com/patternfly/patternfly/master-dist/dist/tests/bootstrap-switch.html ``` ON   OFF ``` Today, the user only has to render an `input`...

So here's my humble opinion...to be more accessible to screen readers, my vote is to add/remove the `checked` attribute on the `input` element as well as changing its `value` in...

+1 for flatpickr on the OSS quality It looks like there is a few themes (Bootstrap is missing unfortunately). Maybe we can pick one and review w/ a CSS expert?...

awesome! this list looks good... i am planning to give the Storybook integration a go this week. I am hoping we can be an early beta tester of integrating Storybooks...