Pratyaksh Sharma
Pratyaksh Sharma
By when we expect this to close?
@agrawalreetika @imjalpreet can you take the first pass here?
@tdcmeehan I guess this is good to merge since it only involves some refactoring. Please have a look. cc: @yzhang1991
Will take a look at it over the weekend.
Going over the github doc for workflow and concurrency as mentioned in the description of this PR. Will review post going through them.
I tested and the changes look good. Here is a sample run that I triggered - https://github.com/prestodb/presto/actions/runs/3359687457. You might want to check why all the checks got cancelled for the...
@permanentstar Does this PR https://github.com/prestodb/presto/pull/18441 help fix your issue?
Based on the discussions in #18542 the changes look good. One small request, please make the first letter of the commit message in uppercase as per the guidelines here -...
@permanentstar Yeah it should be fine, you can probably retrigger the tests by pushing the commit again.
Looks good to me. Thank you for taking care of all the comments patiently. @prestodb/committers please take a pass.