protoc-jar icon indicating copy to clipboard operation
protoc-jar copied to clipboard

Added protoc 3.11.4 for osx-aarch_64.

Open cmardini opened this issue 4 years ago • 24 comments

Built from [email protected]:protocolbuffers/protobuf.git tag v3.11.4

Symbols stripped with "strip"

Built with static linkage: ./configure --disable-shared

% otool -L bin/3.11.4/protoc-3.11.4-osx-aarch_64.exe
bin/3.11.4/protoc-3.11.4-osx-aarch_64.exe:
	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 904.4.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1292.60.1)

Note the license at: https://github.com/protocolbuffers/protobuf/blob/master/LICENSE

cmardini avatar Jan 06 '21 14:01 cmardini

HI guys, do you have some idea when this PR will be merged and published? This will help a lot of M1 users. Thanks.

gabriel-ozeas avatar Apr 07 '21 12:04 gabriel-ozeas

Hi, we need this change too. Can we help some how? Thank you!!

h2000 avatar Apr 29 '21 12:04 h2000

The one single thing that could unstuck this project would be to find some sponsorship. Maybe put in a word with Google or something..

os72 avatar May 04 '21 21:05 os72

The one single thing that could unstuck this project would be to find some sponsorship. Maybe put in a word with Google or something..

Define "sponsorship"? As I need this I am also willing to help on it, but need it for private uses not for my current employer.

jmspring avatar Jun 29 '21 16:06 jmspring

https://github.com/sponsors

os72 avatar Jul 05 '21 23:07 os72

Hi @os72 . Not sure if it's enough (probably not) but I just did a tiny buymeacoffee contribution for you. Just hoping that this PR is merged so that we can use this maven plugin out of the box for M1 macbooks instead of doing any complex workarounds.

abhivaikar avatar Sep 13 '21 09:09 abhivaikar

Hi @os72, Is there a chance you merge this PR ?

maver1ck avatar Nov 16 '21 20:11 maver1ck

hi @os72, Do we have any news about this PR? or any workaround with this version of os72?

Rigoberto-Vazquez avatar Jan 19 '22 17:01 Rigoberto-Vazquez

The one single thing that could unstuck this project would be to find some sponsorship. Maybe put in a word with Google or something..

Hi @os72, you are basically saying, you would rather let this project die if there is no sponsorship to give you the resources to work on this by yourself? Why don't you accept other contributors who actually have the time to work on this in their spare time?

If you don't have the time, kindly let others do what they can. That's part of open source software, isn't it?

daveish avatar Apr 14 '22 02:04 daveish

Hi @os72! I confirmed that we (Spotify) were able to secure corporate sponsorship for protoc-jar. Can we unblock this PR?

clairemcginty avatar May 31 '22 15:05 clairemcginty

Also Google published, in latest version ready artefacts for this architecture - no longer need for custom builds

slachiewicz avatar May 31 '22 18:05 slachiewicz

There is one more option - fork. Maybe Spotify can take this ?

maver1ck avatar May 31 '22 20:05 maver1ck

it's better - this repo can be archived! We have official artefacts from Google.

@clairemcginty plese use something like bellow

https://github.com/protocolbuffers/protobuf/issues/9973

      <plugin>
        <groupId>com.github.os72</groupId>
        <artifactId>protoc-jar-maven-plugin</artifactId>
        <version>3.11.4</version>
       <configuration>
         <protocArtifact>com.google.protobuf:protoc:3.21.1</protocArtifact>

slachiewicz avatar May 31 '22 20:05 slachiewicz

@slachiewicz - you are confusing protoc-jar-maven-plugin with protoc-jar (this project), related but not the same. and yes, both projects have supported downloads from maven central for a long time (google builds or otherwise). you don't even have to specify the artifact syntax, the program will try to find the given version on central automatically

os72 avatar Jun 01 '22 21:06 os72

If you don't have the time, kindly let others do what they can. That's part of open source software, isn't it?

@daveish - not sure i understand this comment, this is open to anyone to modify (keyword fork)..

os72 avatar Jun 01 '22 21:06 os72

Hi @os72! I confirmed that we (Spotify) were able to secure corporate sponsorship for protoc-jar. Can we unblock this PR?

hi @clairemcginty - this is awesome and very appreciated! kudos to spotify for showing some serious OSS leadership

i'm not sure the process has completed, but yes this will help unfreeze the project. hopefully word can spread (beyond just spotify) and help establish a long-term sustainable maintenance level for the project

os72 avatar Jun 01 '22 22:06 os72

When can we expect this to be merged

Naidile-PN avatar Jun 22 '22 13:06 Naidile-PN

Would be really great if you could merge this any time soon

andreaslanderer avatar Jul 06 '22 13:07 andreaslanderer

By when we expect this to close?

pratyakshsharma avatar Sep 20 '22 14:09 pratyakshsharma

One of workarounds for error wth protoc v3.11.4 and JDK 11.0.6 is maven goal parameter:

mvn install -Dos.arch=x86_64

arturCwiklinsky avatar Oct 07 '22 12:10 arturCwiklinsky

I tested this PR and it works perfectly. If the maintainer cannot continue it I suggest someone who can to fork the project and allow others to contribute.

edpichler avatar May 12 '23 12:05 edpichler

Please checkout the fork by BlackRock: https://github.com/blackrock/protoc-jar-maven-plugin

This forked version uses Google’s Protoc version 3.25.1 by default which supports osx aarch64.

spensonshih avatar May 03 '24 09:05 spensonshih

Please checkout the fork by BlackRock: https://github.com/blackrock/protoc-jar-maven-plugin

This forked version uses Google’s Protoc version 3.25.1 by default which supports osx aarch64.

Seems like the README should refer to protoc-maven-plugin? I can only find jars under https://repo1.maven.org/maven2/io/github/blackrock/protoc-maven-plugin/2.0.0/ and not under https://repo1.maven.org/maven2/io/github/blackrock/protoc-jar-maven-plugin/2.0.0/

cmardini avatar May 07 '24 14:05 cmardini

@cmardini , you are correct. This is a missed on my part, thank you for pointing this out. I will get this updated.

spensonshih avatar May 07 '24 15:05 spensonshih