Sirisha Pratha
Sirisha Pratha
> Also I'm not quite sure where/how to add unit tests... this project is surprisingly complex. Any pointers are appreciated. Hi @dmlloyd - Apologies for the late response. I took...
@guw @nikhilnanivadekar can confirm the builds that were failing the last 2-3 days are working fine now.
+1. I second the idea of upgrading the Java version to 11 for our next major version 12.0. @nikhilnanivadekar I do see your point if the versions match( EC 11...
Would be interested to pick this ticket for my first contribution. @nikhilnanivadekar , @donraab - Can you assign the ticket to me?
> @donraab I have updated the project with all the review fixes and unit tests for the changes. Please do review it and let me know if any more changes...
Proposing, that we name this method `collectEachOccurrences` so it reflects that we are iterating/looping?
I have upvoted 👍🏼 for the issue and the use case outlined here: https://github.com/junit-team/junit5/issues/2497#issuecomment-766923020
Hi @nkadhane - could you please 1. remove the commits for updating the surefire-plugin as it has already been addressed in a different PR. 2. squash your commits to 1...
Hi @ivalkshfoeif - can you update your PR , you can do this by - git pull --rebase upstream master git push --force-with-lease
After addressing the comment above, could you squash all your commits to 1 commit?