eclipse
Add toStack to Ordered Primitive Iterable
@donraab I have updated the project with all the review fixes and unit tests for the changes. Please do review it and let me know if any more changes required will be happy to fix them.
@donraab I have updated the project with all the review fixes and unit tests for the changes. Please do review it and let me know if any more changes required will be happy to fix them.
Hi, @DineshPurushothamacharya could you please rebase your PR so one of us can review the changes. Thank you for your contribution!
Hi @DineshPurushothamacharya, I'd like to help get this PR reviewed and merged. There are a couple of changes to start with since this PR has been open for a couple years.
- Update Since tags from 11.0 to 12.0 which will be the next major release
- Rollback the changes to the XML files as they are unrelated to this PR
- Rebase and squash your commits
Thanks!
Hi @DineshPurushothamacharya, I'd like to help get this PR reviewed and merged. There are a couple of changes to start with since this PR has been open for a couple years.
- Update Since tags from 11.0 to 12.0 which will be the next major release
- Rollback the changes to the XML files as they are unrelated to this PR
- Rebase and squash your commits
Thanks!
Hello @donraab, sorry for the huge delay on this PR. I have made all the suggested changes, request you to verify it.
Thanks
Hi @DineshPurushothamacharya, looks like you have some actual issues to fix reported by the checkstyle build. Also, the EclipseFdn ECA check is failing. Do you have a signed ECA on file? If so, I will check and validate what the issue is. Thanks!
Hi @DineshPurushothamacharya, looks like you have some actual issues to fix reported by the checkstyle build. Also, the EclipseFdn ECA check is failing. Do you have a signed ECA on file? If so, I will check and validate what the issue is. Thanks!
Hi @donraab, I have fixed the checkstyle issue and EclipseFdn ECA. Please request to validate.
@donraab , @prathasirisha could you please review this PR? I would like to close this one.
Thank you for the contribution @DineshPurushothamacharya ! I have a couple minor changes requested and after that I will approve and merge.
@donraab Thanks for pointing the mistakes. I have now fixed them. Please check once again and approve if its looks good to you.
Hello @donraab could you please approve and merge this PR?
Hello @donraab, I have fixed the review comments as per your suggestions. Can you please review it and merge this PR?
Hi @DineshPurushothamacharya, I am reviewing now. Thank you for your patience!
Hi @DineshPurushothamacharya, I was hoping to save you the trouble of rebasing your PR and tried using the GitHub Update Branch button for my first time. Unfortunately I did not realize the default behavior of the button is to merge, not rebase. Lesson learned. Would you be able to create a branch, cherry pick your one commit and submit a new PR and make sure it is rebased? I will review/approve and merge the new PR promptly, and close this PR. Thank you, and apologies for the extra work!
Hi @DineshPurushothamacharya, I was hoping to save you the trouble of rebasing your PR and tried using the GitHub Update Branch button for my first time. Unfortunately I did not realize the default behavior of the button is to merge, not rebase. Lesson learned. Would you be able to create a branch, cherry pick your one commit and submit a new PR and make sure it is rebased? I will review/approve and merge the new PR promptly, and close this PR. Thank you, and apologies for the extra work!
Hi @donraab, Thanks for reviewing it. As mentioned I have rebased the changes onto new branch. Please find the new review. Request you to review this one. https://github.com/eclipse/eclipse-collections/pull/1528