Pradyun Gedam

Results 1572 comments of Pradyun Gedam

> What does pip need from build to be able to track in-progress builds? I'm looking at the code now (as part of https://github.com/pypa/pip/pull/10989) and I don't think there's anything...

> If metadata is improperly specified then tools MUST raise an error to notify the user about their mistake. I guess... it depends on what "improperly specified" means? :P None...

https://github.com/pypa/flit/blob/c479f6637b06907128a0c202690ef8ff7f756a8f/flit_core/flit_core/config.py#L410-L411 What @Carreau is referring to, I believe.

> Honestly, I'd be happy enough to decide the warning was a mistake and it should just be an error, without adding a new option. Likewise. I think it's better...

I think so. Someone can try this out, and ensure that it is indeed the case.

FWIW, how to work on this repository for iterating on things like this: - Update the templates. - `nox -s generate` (regenerates the `get-pip.py` files) - `nox -s check-3.9` (runs...

I think things should blow up -- certifi should fail, IIUC -- if removing the whole monkeypatching thing isn't something the code can handle. :)

We should normalise the name generated for the sdist, using the same rules as wheels. That'll avoid the weird error message?

Whelp, before we merge this, we need to update the CI checks to account for untracked files being generated by the generate script.

I think the CI should fail, if files that are going to be generated by the generation script are not checked in. Right now, it's not doing that. In other...