get-pip icon indicating copy to clipboard operation
get-pip copied to clipboard

Is monkeypatch_for_cert needed any more?

Open pfmoore opened this issue 2 years ago • 4 comments

Nowadays, pip extracts the cert bundle from certifi to a temporary file (see #pip/10753). As far as I can see, monkeypatch_for_cert here does basically the same thing.

Could we just remove that function?

pfmoore avatar Dec 28 '21 20:12 pfmoore

I think so. Someone can try this out, and ensure that it is indeed the case.

pradyunsg avatar Jan 06 '22 09:01 pradyunsg

I might have a go at that if & when I can work out how I'd test such a change... But if anyone else gets to it first, I won't object 🙂

pfmoore avatar Jan 06 '22 09:01 pfmoore

FWIW, how to work on this repository for iterating on things like this:

  • Update the templates.
  • nox -s generate (regenerates the get-pip.py files)
  • nox -s check-3.9 (runs the relevant script in a clean venv)

pradyunsg avatar Jan 06 '22 12:01 pradyunsg

I think things should blow up -- certifi should fail, IIUC -- if removing the whole monkeypatching thing isn't something the code can handle. :)

pradyunsg avatar Jan 06 '22 12:01 pradyunsg