Pradyun Gedam

Results 1572 comments of Pradyun Gedam

FWIW, another example of the sort of situation this would trip on would be when adding 3.7 to the mapping on top (i.e. logic for generating public/3.7/get-pip.py), but not adding...

> I'm not quite sure why, but because this PR means we'll have more risk of forgetting to check in the newly generated files? Because this PR is adding new...

I’d argue that we should also have signatures and checksums on these files, at some point in the future (like we should for get-pip.py, as the open issues suggest), so...

> then we have CI that checks that the generate produces the files we just added (I don't really understand what we're trying to check against) I guess I never...

We can't have redirects, since a common mechanism is using curl, which won't be happy with redirects.

I don't think jsDelivr's model works for us -- we don't follow SemVer and, realistically, "get me something for my Python version" is much easier to support than get-me-a-specific-version. ---...

Yup yup. That's why I've been making all the changes in this repository recently. ;)

Alrighty, we can now do this. It's a matter of updating the following dictionary: https://github.com/pypa/get-pip/blob/5a43acd2179f77d4e6385aa766cc7d7542d2eff7/scripts/generate.py#L20-L56 And updating the logic for how we determine the "minimum supported version" for the "default"...

Oh, I just realized... we do get the `requires_python` key in the JSON from PyPI -- we can use that information to populate the pip pin! We can probably remove...