Gregory Brown

Results 38 comments of Gregory Brown

Bumping this one again to remind myself to implement. Just ran into it another time.

@johnnyshields: Please don't advertise bounties in the tracker. It's fine for you to offer them, but do so by private email instead.

@grzesiek: See the last comment on #31 from @hbrandl for a summary of what to think about if you want to work on a pull request.

@hbrandl: Refactored code would be nice, but formal high-level documentation of the computations we're implementing is better. Keep in mind that an "A" in code climate does not imply understandability...

In other words, clean code will certainly help make fixes easier, but documentation of how things are supposed to work has both preventative effect and an educational effect that clean...

I really don't think this is a good idea to depend so heavily on Code Climate scores. They only measure extremely local internal quality issues! I care much more about...

@hbrandl: I use code climate metrics for Prawn core occasionally, but usually for my own cleanup work, rather than asking contributors to pay attention to them. I should have probably...

@straydogstudio: Thanks. The basic idea is that if we can have some decent documentation on how the code is supposed to work, we can verify that (a) the testing is...

We definitely don't do anything with orientation currently. You can investigate further and consider preparing a patch if you'd like.

There may have been a regression, can you build from the stable branch and see if it fixes the problem? -greg