prawn-table icon indicating copy to clipboard operation
prawn-table copied to clipboard

Multi-page cells should only show top/bottom borders on first/last page of the cell

Open johnnyshields opened this issue 9 years ago • 9 comments

As a follow-up to PR #16, cells which split across multiple pages should only have top and bottom borders on the first and last pages respectively (refer to image). This would give a visual cue to readers that the cell spans to the next page.

image

johnnyshields avatar Nov 03 '14 12:11 johnnyshields

Hi !

What is status of #31 and #16 ?. I think this is very essential feature, as at this moment we are losing data (text is truncated when it doesn't fit cell on single page).

Cheers, Grzegorz

grzesiek avatar Feb 03 '15 12:02 grzesiek

@grzesiek, @hbrandl was working on a fix but it's a very complex issue. We were discussing a bounty to solve this problem, if you are willing to chip-in please get in touch with me.

johnnyshields avatar Feb 03 '15 13:02 johnnyshields

@johnnyshields: Please don't advertise bounties in the tracker. It's fine for you to offer them, but do so by private email instead.

practicingruby avatar Feb 03 '15 13:02 practicingruby

@johnnyshields: I really need this feature, so I can help in solving that issue

grzesiek avatar Feb 03 '15 13:02 grzesiek

@grzesiek: See the last comment on #31 from @hbrandl for a summary of what to think about if you want to work on a pull request.

practicingruby avatar Feb 03 '15 13:02 practicingruby

@sandal I've already seen it, I'll try to investigate this better when I find some time

grzesiek avatar Feb 03 '15 13:02 grzesiek

OK. It may make sense to discuss with @hbrandl directly as well, I think he ultimately felt his currently committed approach was not adequate for the complexity of the feature and may have some ideas on what he would do if he were to attempt it again.

johnnyshields avatar Feb 03 '15 14:02 johnnyshields

@grzesiek as @johnnyshields indicated the issue is a very complex one. The design decision I made when trying to implement it turned out to be wrong. That's why I gave up on it.

It would be an awesome feature to have. And depending on your use case the code in #31 might work. However in lots of complex szenarios the formatting will completely break.

I tried to give an outline of the complexity in my last comment on #31. Since this issue (#30) is about something else, please direct any discussion to #31 or #3.

hbrandl avatar Feb 03 '15 20:02 hbrandl

Is there any workaround here for the multipage row span issue ?

ashiksp avatar Jan 16 '18 21:01 ashiksp