Paul Pfeister
Paul Pfeister
Hm. Actually... minor hold up. This will likely break existing installations. We should push a new version before merging this. Let me make a few changes and we'll be pushing...
Additional nice-to-have ---- If we could configure cache settings by environment variable, that would be extremely useful in terms of automations and containerized environments i.e. `SHERLOCK_CACHE_DISABLE=True` (setting --skip-cache or whatever...
I don't have the time to validate this tonight but the hacktoberfest-accepted label has been added so we don't have to rush testing & merging This is looking good so...
Will probably get around to a closer review this weekend. Preliminary checks all looked good though. Wondering if we should drop the TTL to something like 3 or 6 hours,...
Integration is easy enough and functional, but it returns either too many or too few hits at this time. Needs some tweaking before merging. Shooting for finalization before 0.17.0.
Did you confirm that the maximum username length is actually 50 chars? If so, that'll be a stronger pattern to use than a wildcard quantifier.
Looks like 2-15 rather than 1-50? Are there legacy accounts with the larger range, maybe?
Can't believe this wasn't caught yet. Good one! > Also, let me know if you agree with the extended more fail-proof solution of updating the pipeline to catch failures that...
Busy weekend so unable to opine on fixes right this second ---- but on the header patch.... no site-specific modifications should be made to the core of the project. However,...
Could you guys try this with `sherlock -j 2689 --site LinkedIn {usernames}` and report back with results? Passes tests on our end. (Possible fix in #2689)