sherlock-project
Fix dailykos F+
dailykos uses CloudFront geo-restrictions that return 403 errors for blocked regions, causing false positives in username detection. Added comment to document this known issue.
Automatic validation of changes
| Target | F+ Check | F- Check |
|---|---|---|
| dailykos | :heavy_check_mark: Pass | :heavy_check_mark: Pass |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Good catch. One of the downfalls of message checks.
Are you in an allowed region or a blocked one? Could be useful in validating alternatives to eliminate it by the 403, as well.
Good catch. One of the downfalls of message checks.
Are you in an allowed region or a blocked one? Could be useful in validating alternatives to eliminate it by the 403, as well.
Sir , I'm in a blocked region (testing from India/Asia) , while testing endpoint got , Probe URL also returns 403 with geo-block message curl -k "https://www.dailykos.com/signup/check_nickname?nickname=testuser" Returns: "The Amazon CloudFront distribution is configured to block access from your country"
It hasn't even been 24hr since my last comment, people have jobs
Sorry sir , if i have offended u ...
No worries, things just take time
Could you checkout the feat/multiple-types branch found in #2597 and try this command?
poetry run sherlock --site dailykos uirgheerig blue --local --print-all
Attempting an alternative resolution for this issue that may help with other sites as well. If this works, I'll be reverting the dailykos change in that PR so you can make the site change yourself with the new feature (and get credit for hacktoberfest).
No worries, things just take time
Could you
checkoutthe feat/multiple-types branch found in #2597 and try this command?
poetry run sherlock --site dailykos uirgheerig blue --local --print-allAttempting an alternative resolution for this issue that may help with other sites as well. If this works, I'll be reverting the dailykos change in that PR so you can make the site change yourself with the new feature (and get credit for hacktoberfest).
Successfully tested the feat/multiple-types branch!
Command executed: poetry run sherlock --site dailykos uirgheerig blue --local --print-all Output: [*] Checking username uirgheerig on:
[-] dailykos: Not Found!
[*] Checking username blue on:
[-] dailykos: Not Found!
[*] Search completed with 0 results So , sir the alternative solution works perfectly . No 403 geo-restriction errors from my blocked region (India). Both test usernames correctly returned "Not Found!" instead of false positives.
Merged #2597 into master (without dailykos).
If you could git reset --hard 1d2c4b134f8125c4fdacc3d7cc107ec442832f33 and then simply change the errorType to "errorType": ["message", "status_code"] instead of "errorType": "message", that should be good!
Once you make the change and commit, you can overwrite the branch on this PR by git push --force-with-lease
(some of the automatic tests here will probably fail, that is expected with this change ---- no worries)
Automatic validation of changes
| Target | F+ Check | F- Check |
|---|---|---|
| Roblox | :x: Fail | :heavy_check_mark: Pass |
| dailykos | :heavy_check_mark: Pass | :heavy_check_mark: Pass |
| SlideShare | :x: Fail | :heavy_check_mark: Pass |
| threads | :x: Fail | :heavy_check_mark: Pass |
| CyberDefenders | :heavy_check_mark: Pass | :heavy_check_mark: Pass |
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).
Huh. They all worked. Even better.
Anyways, LGTM! Merging into master now
(some of the automatic tests here will probably fail, that is expected with this change ---- no worries)
ok sir , i have done the changes , as told
Hm. Actually... minor hold up.
This will likely break existing installations. We should push a new version before merging this.
Let me make a few changes and we'll be pushing 0.17.0 or 0.16.1 shortly. This will be merged alongside.
Tagging this as accepted though so it's counted by hacktoberfest while pending that change.
Hm. Actually... minor hold up.
This will likely break existing installations. We should push a new version before merging this. Let me make a few changes and we'll be pushing
0.17.0or0.16.1shortly. This will be merged alongside.Tagging this as accepted though so it's counted by hacktoberfest while pending that change.
Thank You sir for guiding me , looking forward to seeing this in v0.17.0 and thank you for marking it as hacktoberfest-accepted